Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop unrequired capabilities from containers #677

Merged
merged 1 commit into from
May 25, 2023
Merged

Drop unrequired capabilities from containers #677

merged 1 commit into from
May 25, 2023

Conversation

ciarams87
Copy link
Member

Proposed changes

Drop all unrequired capabilities from containers in the nginx-gateway deployment manifest

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@ciarams87 ciarams87 requested a review from a team as a code owner May 24, 2023 15:04
@github-actions github-actions bot added the enhancement New feature or request label May 24, 2023
pleshakov
pleshakov approved these changes May 25, 2023
View reviewed changes
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kate-osborn kate-osborn self-requested a review May 25, 2023 15:36
@ciarams87 ciarams87 merged commit 8a19254 into nginxinc:main May 25, 2023
@ciarams87 ciarams87 deleted the feat/drop-unrequired-caps branch May 25, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kate-osborn kate-osborn kate-osborn approved these changes

@sjberman sjberman sjberman approved these changes

@pleshakov pleshakov pleshakov approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
NGINX Gateway Fabric
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ciarams87 @pleshakov @sjberman @kate-osborn